-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated metadata #231
base: master
Are you sure you want to change the base?
updated metadata #231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please document a bit more
bdrc_id: str | ||
location_info: dict | ||
diplomatic_id:Optional[List[str]] | ||
alignmnet_ids:Optional[List[str]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be alignment
colophon: str | ||
authors: List[str] | ||
bdrc_id: str | ||
location_info: dict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does that mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but that's not really how it should work: the design of the metadata in OpenPecha shouldn't be driven by some query I made quickly a few months ago, there should be some proper design effort to create good OpenPecha metadata, document it and then build a query to get this data from BDRC
language: str | ||
bdrc_work_id: str | ||
authors: List[str] | ||
best_instance:Optional[InstanceMetadata] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't that be best_instance_id: str
instead?
alignment_to_base:Dict[str,str] | ||
source_metadata: Optional[Dict] = None | ||
|
||
class InstanceMetadata(BaseModel): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you document a little bit what an instance, an alignment, a work and a collection are? My intuition is that instances should not have authors but should instead have works, but since it's all a bit unclear I'm not sure
hey,I have update the openpecha.core.metadata with the work metadata,instance metadata and alignment metadata.