Enhance: Edit page #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test is pending for now |
| { account: "x.com", url: userInfo["x.com"] || "" }, | ||
| { account: "linkedin", url: userInfo.linkedIn || "" }, | ||
| { account: "facebook", url: userInfo.facebook || "" }, | ||
| { account: "profile.twitter", url: userInfo["x.com"] || "" }, |
There was a problem hiding this comment.
i have a doubt whether it will work if you change x.com to profile.twitter.
because backend needs to receive the key as x.com and we are mapping this key as the payload, maybe will check tonight
There was a problem hiding this comment.
let me know after the check . if it is still the issue, we can revert this changes and instead make changes in the tolgee itself
There was a problem hiding this comment.
- i dont think it will work
the key names should just something like "x.com". "linkedin", etc
else wont be accepted by the backend
- also the colors that is being used, we might have to confirm on that, i dont think it is yellow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34
this pr is for the enhancement of the edit page
it includes