Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/art/unsloth/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,21 @@ async def train(
) -> AsyncIterator[dict[str, float]]:
# Get the packed tensors from disk
packed_tensors = packed_tensors_from_dir(**disk_packed_tensors)
# Wait for existing batches to finish
await self.results_queue.join()
# Wait for existing batches to finish, with timeout to prevent deadlock
try:
await asyncio.wait_for(self.results_queue.join(), timeout=10.0)
except asyncio.TimeoutError:
# Recover from deadlock by draining queue
drained = 0
while True:
try:
self.results_queue.get_nowait()
self.results_queue.task_done()
drained += 1
except asyncio.QueueEmpty:
break
if verbose and drained > 0:
print(f"Warning: Drained {drained} lingering result(s) from queue")
# If we haven't already, start the training task
if self._train_task is None:
self._train_task = asyncio.create_task(
Expand Down