Merge CI test into workflow with fixed tests #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original repo is from branch ci23 of https://github.com/pranjanpr/libcupsfilters. The test fails which requires to be fixed. Signed-off-by: TTFISH <[email protected]> Co-authored-by: pranjanpr <[email protected]>
Signed-off-by: TTFISH <[email protected]>
Signed-off-by: TTFISH <[email protected]>
cupsfilters/test-filter-cases.txt required further checks for the last two test cases Potential output: ERROR: cfFilterUniversal: Unsupported combination of input and output formats: application/pdf -> image/jpeg Signed-off-by: TTFISH <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although previous contributors has developped CI tests and added testfilters as unit tests, the code is not merged into master branch.
The previous code is developed by @pranjanpr. The original code space is: https://github.com/pranjanpr/libcupsfilters/tree/ci23.
Current CI test works properly.
Note: two test cases below in
test-filter-cases.txtwould somehow pop error messagesERROR: cfFilterUniversal: Unsupported combination of input and output formats: image/urf -> image/jpegwhich requires further debugging.