Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible spoofed events in ClaimManager #134

Open
FlacoJones opened this issue Mar 7, 2023 · 0 comments
Open

Possible spoofed events in ClaimManager #134

FlacoJones opened this issue Mar 7, 2023 · 0 comments

Comments

@FlacoJones
Copy link
Contributor

THE EXPLOIT

We added a bountyExists check in DepositManager::fundBountyToken to prevent event spoofing. This is good.

We DID NOT add the same bountyExists protection on ClaimManagerV1::permissionedClaimTieredBounty(address,bytes) or ClaimManagerV1::claimBounty.

This would cause spoofed ClaimSuccess, TokenBalanceClaimed, and BountyClosed events to be emitted.

It DOES NOT risk funds since the transfer methods only transfers the bounty addresses balance, which the attacker would not control

THE FIX

Add the same bountyExists check to permissionedClaimTieredBounty(address,bytes) and claimBounty(address,address,bytes)

The best practice violation was just a missing onlyProxy on the ClaimManager pause methods

THE IMPACT

  1. Our subgraph used in the frontend consumes these events. Data inconsistency can nuke much of our frontend logic.

  2. We send emails to both claimants and event organizers based off of these events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant