Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix review claim event spoof #133

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Conversation

FlacoJones
Copy link
Contributor

@FlacoJones FlacoJones commented Mar 7, 2023

  • Add the same bountyExists check that protects against event spoofing in DepositManagerV1 to the ClaimManagerV1 methods permissionedClaimTieredBounty(address,bytes) and claimBounty(address,address,bytes)

  • Adds onlyProxy to ClaimManagerV1::pause and ClaimManagerV1::unpause

  • Remove codepath to call _claimTieredFixedBounty from the onlyOracle ClaimManagerV1::claimBounty method. There is no scenario where this would be needed right now, and introduced the ability to drain contracts in the event of an oracle compromise.

  • Adds whenNotPaused to ClaimManagerV1::claimBounty

Closes #134

@IAm0x52
Copy link

IAm0x52 commented Mar 9, 2023

Fixes look good. bountyExists check protects against even spoofing. claimBounty is now protected by pause. Claiming tiered bounties is now always pull rather than push or pull.

@FlacoJones FlacoJones merged commit d363e59 into staging Mar 9, 2023
@FlacoJones FlacoJones deleted the fix-review-claim-event-spoof branch August 10, 2023 02:29
@FlacoJones FlacoJones restored the fix-review-claim-event-spoof branch August 10, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants