Skip to content

Commit

Permalink
openrc-run: chdir into HOME for user services.
Browse files Browse the repository at this point in the history
some services might expect to be in home, and may behave unexpectedly
for the user, e.g. any program started via dbus, and this matches
systemd-user behaviour.
  • Loading branch information
navi-desu committed Sep 21, 2024
1 parent 5324525 commit 995ef05
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions src/openrc-run/openrc-run.c
Original file line number Diff line number Diff line change
Expand Up @@ -1148,6 +1148,7 @@ int main(int argc, char **argv)
RC_STRING *svc;
char service_path[PATH_MAX];
char *initdir, *scriptdir;
const char *workingdir = "/";
char *save;
char *pidstr = NULL;
size_t l = 0, ll;
Expand Down Expand Up @@ -1186,8 +1187,12 @@ int main(int argc, char **argv)
if (argc < 3)
usage(EXIT_FAILURE);

/* Change dir to / to ensure all init scripts don't use stuff in pwd */
if (chdir("/") == -1)
/* Change dir to / to ensure all init scripts don't use stuff in pwd
* For user services, change to the user's HOME instead. */
if (rc_is_user() && !(workingdir = getenv("HOME")))
eerrorx("HOME is unset.");

if (chdir(workingdir) == -1)
eerror("chdir: %s", strerror(errno));

if ((runlevel = xstrdup(getenv("RC_RUNLEVEL"))) == NULL) {
Expand Down

0 comments on commit 995ef05

Please sign in to comment.