librc.c: fix potential infinite loop in recusive_mkdir

Signed-off-by: Anna (navi) Figueiredo Gomes <[email protected]>
OpenRC · Jun 20, 2023 · e12ddac · e12ddac
1 parent 5bddd26
commit e12ddac
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/librc/librc.c b/src/librc/librc.c
@@ -133,15 +133,13 @@ recursive_mkdir(const char *pathname, int mode)
 		return 0;
 	}
 
-	for (p = dir + 1; p; p++) {
-		if (*p == '/') {
-			*p = '\0';
-			if (mkdir(dir, mode) != 0 && errno != EEXIST) {
-				free(dir);
-				return -1;
-			}
-			*p = '/';
+	for (p = strchr(dir + 1, '/'); p; p = strchr(p + 1, '/')) {
+		*p = '\0';
+		if (mkdir(dir, mode) != 0 && errno != EEXIST) {
+			free(dir);
+			return -1;
 		}
+		*p = '/';
 	}
 
 	if (stat(dir, &sb) != 0) {