add github action to perform shellcheck on scripts #465
Conversation
| *) continue ;; | ||
| esac | ||
| echo "Checking ${shellscript} with shellcheck:" | ||
| shellcheck -s sh "${shellscript}" || true |
There was a problem hiding this comment.
this ignores all errors, so this job will never fail. since it will always be green (in the actions tab, and in PRs), no one will ever look at it. so like, what's the point ? :)
i think you want to set ret=0 at the top of the file, change this true to ret=1, and then exit ${ret} at the bottom.
There was a problem hiding this comment.
Ultimately, my thought is to change the "true" to "exit" to bail immediately once a script fails shellcheck, but I can't do that yet because I'll need to figure out which messages are false positives so they can be turned off in a configuration file or in the source files themselves.
There was a problem hiding this comment.
none of the CI checks block merges or pushes, so i think it'd be OK to just land this as-is. but i'm fine with an exit 0 at the end of the script with a TODO explaining why it's ignoring the $ret if you want to go that route.
williamh
force-pushed
the
ci-shellcheck
branch
from
c3bb962
to
6dd9397
Compare
No description provided.