CI: Add github code quality analysis (codeql) #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following patch should solve one of the issues reported in the codeql scan. It also removes usage of diff --git a/src/swclock/swclock.c b/src/swclock/swclock.c
index e526bd38..83b15c95 100644
--- a/src/swclock/swclock.c
+++ b/src/swclock/swclock.c
@@ -78,14 +78,12 @@ int main(int argc, char **argv)
eerrorx("swclock: Reference file was not specified");
if (sflag) {
- if (stat(file, &sb) == -1) {
- opt = open(file, O_WRONLY | O_CREAT, 0644);
- if (opt == -1)
- eerrorx("swclock: open: %s", strerror(errno));
- close(opt);
- } else
- if (utime(file, NULL) == -1)
- eerrorx("swclock: utime: %s", strerror(errno));
+ int fd = open(file, O_WRONLY | O_CREAT, 0644);
+ if (fd == -1)
+ eerrorx("swclock: open: %s", strerror(errno));
+ if (futimens(fd, NULL) == -1)
+ eerrorx("swclock: futimens: %s", strerror(errno));
+ close(fd);
return 0;
}
Footnotes |
|
can you send a PR ? we're not going to copy & paste patches from comments ... |
Sure. I was thinking @thesamesam might have wanted to add that to this PR since it's somewhat related. EDIT: done at #591 |
vapier
reviewed
Jan 29, 2023
| pull_request: | ||
| # The branches below must be a subset of the branches above | ||
| branches: [ "master" ] | ||
| schedule: |
There was a problem hiding this comment.
why do we need a schedule for it when it already fires on pushes & pull requests ?
| @@ -0,0 +1,52 @@ | |||
| name: "CodeQL" | |||
There was a problem hiding this comment.
should have a comment block at the top explaining what this is about and links to relevant docs
| # By default, queries listed here will override any specified in a config file. | ||
| # Prefix the list here with "+" to use these queries and those in the config file. | ||
|
|
||
| # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.