meson: drop broken split-usr handling #696
Conversation
thesamesam
force-pushed
the
meson-split-usr
branch
from
8995349
to
e998353
Compare
It is required for non-Gentoo package managers on distros that only support one or the other of split-usr/ merged-usr, and have chosen merged-usr. Symlinks may be here to stay, but not all package managers perform install-time resolution of symlinks when calculating whether or not the package queued for installation has conflicts with existing files on disk e.g. owned by another package. In such a scenario, you will easily find yourself installing files to /sbin/* and having them conflict another "file", the /sbin symlink. It's therefore correct to always refer to the file by its canonical portable name, but when copying files over to DESTDIR a bit more care is needed. This isn't an issue when directly installing without a staged DESTDIR, and it isn't a problem if you work around the problem by |
|
That's a fair point. But for such cases, they can set |
thesamesam
force-pushed
the
meson-split-usr
branch
from
e998353
to
c73b902
Compare
Two issues here: * The 'split-usr' meson option wasn't doing anything, it tried to check if /bin was a symlink, but nothing acted on this information. * The actual rootprefix default was decided based on whether /bin was a symlink which is flaky if e.g. building on a merged-usr system for use on a non-merged-usr system. People can set -Drootprefix=/usr if they wish. There's no real advantage to installing to /usr over / as the compat. symlinks are really here to stay. If someone really does care about this, they can bring it back and do it properly, but it doesn't seem worth it to me at all. Bug: https://bugs.gentoo.org/927776 Fixes: cc0037e Fixes: f2362cc
thesamesam
force-pushed
the
meson-split-usr
branch
from
c73b902
to
8380cc0
Compare
Two issues here: * The 'split-usr' meson option wasn't doing anything, it tried to check if /bin was a symlink, but nothing acted on this information. * The actual rootprefix default was decided based on whether /bin was a symlink which is flaky if e.g. building on a merged-usr system for use on a non-merged-usr system. People can set -Drootprefix=/usr if they wish. There's no real advantage to installing to /usr over / as the compat. symlinks are really here to stay. If someone really does care about this, they can bring it back and do it properly, but it doesn't seem worth it to me at all. Bug: https://bugs.gentoo.org/927776 Fixes: cc0037e Fixes: f2362cc Fixes: #696
meson: drop broken split-usr handling
Two issues here:
The 'split-usr' meson option wasn't doing anything, it tried to check
if /bin was a symlink, but nothing acted on this information.
The actual rootprefix default was decided based on whether /bin was a symlink
which is flaky if e.g. building on a merged-usr system for use on a non-merged-usr
system.
People can set -Drootprefix=/usr if they wish.
There's no real advantage to installing to /usr over / as the compat. symlinks
are really here to stay. If someone really does care about this, they can bring
it back and do it properly, but it doesn't seem worth it to me at all.
Bug: https://bugs.gentoo.org/927776
Fixes: cc0037e
Fixes: f2362cc