Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xgetline helper and drop rc_getline #747

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add xgetline helper and drop rc_getline #747

merged 2 commits into from
Sep 24, 2024

Conversation

navi-desu
Copy link
Member

No description provided.

rc_getline is an implementation from when getline wasn't available on
most libcs, and is planned for removal, however much of of the code
relies on it's behaviour of removing new lines at the end of strings.

To avoid duplicating the new line removal logic in a dozen places, we
introduce a new helper function xgetline, which just wraps around
getline but removes the new line at the end.
getline(3) got standardized in posix 2008 and is common place on all
libc implementations now a days, and rc_getline is tagged for removal
for ages now.
@williamh williamh merged commit cadc1d2 into master Sep 24, 2024
8 checks passed
@williamh williamh deleted the xgetline branch September 24, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants