Add xgetline helper and drop rc_getline #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-R-K
reviewed
Sep 19, 2024
rc_getline is an implementation from when getline wasn't available on most libcs, and is planned for removal, however much of of the code relies on it's behaviour of removing new lines at the end of strings. To avoid duplicating the new line removal logic in a dozen places, we introduce a new helper function xgetline, which just wraps around getline but removes the new line at the end.
getline(3) got standardized in posix 2008 and is common place on all libc implementations now a days, and rc_getline is tagged for removal for ages now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.