Remove rootprefix #748
Merged
Remove rootprefix #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navi-desu
requested changes
Sep 19, 2024
navi-desu
reviewed
Sep 19, 2024
|
As I mentioned on IRC, these need proper commit messages including the full context and should not be squashed either. |
|
there's still a few things for us to cleanup and improve with meson, but that can be done on a later PR, overall the code LGTM |
williamh
force-pushed
the
rm-rootprefix
branch
3 times, most recently
from
038e5f5
to
12bc1ca
Compare
This change removes the ROOTPREFIX build setting.
If your OS expects to have / mounted earlier in the boot process than
/usr, you will need to pass the appropriate directory settings to "meson
setup" as part of the build process, for example:
$ meson setup \
--bindir /bin --libdir /lib64 --libexecdir /lib --sbindir /sbin \
build
also, move plugins to ```libdir/rc/plugins``` which is the standard
location for plugins accessed via dlopen.
williamh
force-pushed
the
rm-rootprefix
branch
from
12bc1ca
to
756f64a
Compare
navi-desu
reviewed
Sep 23, 2024
navi-desu
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.