Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4 #7

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Issue 4 #7

merged 1 commit into from
Dec 17, 2024

Conversation

sunilnatraj
Copy link
Collaborator

Changed label of fileChecksum to sha256

@sunilnatraj
Issue 4
e83b1f6 
Changed label of fileChecksum to sha256
@sunilnatraj sunilnatraj requested a review from wetneb December 17, 2024 10:51
@sunilnatraj sunilnatraj mentioned this pull request Dec 17, 2024
Closed
wetneb
wetneb approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But the fact that the build passes without any changes to the tests indicates that it could be good to have better tests, no?

@sunilnatraj
Copy link
Collaborator Author

@wetneb Good point; I will expand the tests to check data as well.

@sunilnatraj sunilnatraj merged commit c7b21c5 into master Dec 17, 2024
2 checks passed
@sunilnatraj sunilnatraj deleted the issue-4 branch December 17, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetneb wetneb wetneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunilnatraj @wetneb