Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct types on get_modstate/1 #13

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Correct types on get_modstate/1 #13

merged 1 commit into from
Sep 16, 2024

Conversation

martinsumner
Copy link

@martinsumner martinsumner commented Sep 12, 2024 •
edited
Loading

riak_core_vnode does not determine what type is used as the ModState.

ThomasArts
ThomasArts approved these changes Sep 16, 2024
View reviewed changes
Copy link

@ThomasArts ThomasArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch... this may be a totally different state than the one used in the caller module

@martinsumner martinsumner merged commit f74ba92 into nhse-develop-3.4 Sep 16, 2024
2 checks passed
@martinsumner martinsumner deleted the nhse-d34-nhsrt.i21-modstatetypes branch September 16, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasArts ThomasArts ThomasArts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinsumner @ThomasArts