Use selective receive to allow for vnode to be blocked #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Block and unblock a vnode when triggering a repair. Otherwise their is a potential race condition: - aae_controller is triggered into repair mode, queueing all updates to be re-applied after rebuild complete - update is applied to leveled backend by vnode - snapshot is taken for rebuild (including update) - message is cast to aae_controller with update ... which will be queued and applied twice - update is queue
If the selective receive times out - then need to handle the release message
|
Looks good. It could be a good idea to make |
ThomasArts
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block and unblock a vnode when triggering a repair. Otherwise their is a potential race condition: