Improved dup-key test

OpenSC · Oct 21, 2024 · f108fb2 · f108fb2
1 parent 4dc8cb5
commit f108fb2
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/tests/dup-key.c b/tests/dup-key.c
@@ -120,6 +120,11 @@ int main(int argc, char *argv[])
 		goto end;
 	}
 
+	/*
+	 * ENGINE_init() returned a functional reference, so free the structural
+	 * reference from ENGINE_by_id().
+	 */
+	ENGINE_free(engine);
 	pkey = ENGINE_load_private_key(engine, privkey, 0, 0);
 
 	if (pkey == NULL) {
@@ -158,15 +163,15 @@ int main(int argc, char *argv[])
 	/* Do it one more time */
 	pkey = ENGINE_load_private_key(engine, privkey, 0, 0);
 
+	/* Free the functional reference from ENGINE_init */
+	ENGINE_finish(engine);
 	if (pkey == NULL) {
 		printf("Could not load key\n");
 		display_openssl_errors(__LINE__);
 		ret = 1;
 		goto end;
 	}
 
-	ENGINE_finish(engine);
-
 	ret = 0;
 
 	CONF_modules_unload(1);