Prevent segfault after ctx_finish(). #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes OpenSC#509 At the same time, it tightens the condition in the test that made it impossible to indicate this segfault. modified: src/eng_front.c modified: tests/search-all-matching-tokens.softhsm
No, it doesn't. It only hides a bug in SoftHSMv2. The issue was fixed in opendnssec/SoftHSMv2@1ecfde4 and then broken again by @agrandville in opendnssec/SoftHSMv2@f1a8474. Also see opendnssec/SoftHSMv2#181. |
|
Ok, thanks for the link to the problem with softhsm. I am canceling this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #509
At the same time, it tightens the condition in the test that made it impossible to indicate this segfault.