Merge pull request #244 from jan-cerny/remediations

Hide some remediation types
OpenSCAP · Jul 31, 2024 · 1a18bfb · 1a18bfb
2 parents 60dc569 + 81dc3d8
commit 1a18bfb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/openscap_report/scap_results_parser/data_structures/remediation.py b/openscap_report/scap_results_parser/data_structures/remediation.py
@@ -12,6 +12,11 @@
     "fix",
 ]
 
+HIDDEN_REMEDIATION_TYPES = [
+    "urn:redhat:anaconda:pre",
+    "urn:xccdf:fix:script:kickstart",
+]
+
 
 @dataclass
 class Remediation:
@@ -33,5 +38,6 @@ def get_type(self):
             "urn:redhat:anaconda:pre": "Anaconda snippet",
             "urn:xccdf:fix:script:kubernetes": "Kubernetes snippet",
             "urn:redhat:osbuild:blueprint": "OSBuild Blueprint snippet",
+            "urn:xccdf:fix:script:kickstart": "Kickstart snippet",
         }
         return script_types.get(self.system, "script")
diff --git a/openscap_report/scap_results_parser/parsers/rule_parser.py b/openscap_report/scap_results_parser/parsers/rule_parser.py
@@ -6,6 +6,7 @@
 from openscap_report.dataclasses import replace
 
 from ..data_structures import Identifier, Reference, Rule, RuleWarning
+from ..data_structures.remediation import HIDDEN_REMEDIATION_TYPES
 from ..namespaces import NAMESPACES
 from .full_text_parser import FullTextParser
 from .known_references import KNOWN_REFERENCES, update_references
@@ -58,6 +59,8 @@ def _get_remediations(self, rule):
         output = []
         for fix in rule.findall(".//xccdf:fix", NAMESPACES):
             remediation = self.remediation_parser.get_remediation(fix)
+            if remediation.system in HIDDEN_REMEDIATION_TYPES:
+                continue
             output.append(remediation)
         return output