Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty Value property value #209

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Aug 8, 2023

This PR fixes crashes caused by empty values in the Value component. It is represented as None instead of an empty string in the lxml parser. The value of the Value component that was used during the scan is obtained from the set-value elements. In this case, it represents a self-closing set-value tag.

The ID of the Value component that caused the problem is xccdf_org.ssgproject.content_value_var_pam_wheel_group_for_su.

Fixes: #207

@Honny1 Honny1 marked this pull request as ready for review August 8, 2023 14:59
@Honny1 Honny1 requested a review from jan-cerny August 9, 2023 09:00
@jan-cerny jan-cerny self-assigned this Aug 11, 2023
Copy link
Member

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the issue #207 for me. I have tried to generate some reports based on Automatus results and they also look OK.

@jan-cerny jan-cerny merged commit 065c407 into OpenSCAP:main Aug 11, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traceback when generating reports from ARF coming from Automatus tests
2 participants