MVP Push #5

uwtcat · 2018-02-05T01:21:38Z

No description provided.

nbolten · 2018-02-05T01:24:41Z

app/build.gradle

@@ -1,14 +1,16 @@
 apply plugin: 'com.android.application'
-apply plugin: 'com.neenbedankt.android-apt'
+//apply plugin: 'com.neenbedankt.android-apt'


Delete instead of comment, please!

nbolten · 2018-02-05T01:26:22Z

app/src/main/java/de/westnordost/streetcomplete/MainActivity.java

 		OsmQuestAnswerListener, VisibleQuestListener, QuestsMapFragment.Listener, MapFragment.Listener
 {
-	@Inject CrashReportExceptionHandler crashReportExceptionHandler;
+ Queue<Quest> questsToDo;	@Inject CrashReportExceptionHandler crashReportExceptionHandler;


Separate lines please!

nbolten · 2018-02-05T01:27:52Z

app/src/main/java/de/westnordost/streetcomplete/data/osm/SimpleOverpassQuestType.java

@@ -1,5 +1,7 @@
 package de.westnordost.streetcomplete.data.osm;

+import android.util.Log;


Fine to leave the logging so long as the debug level (Log.d?) is disabled in production!

nbolten · 2018-02-05T01:28:25Z

app/src/main/java/de/westnordost/streetcomplete/quests/QuestModule.java

 import de.westnordost.streetcomplete.data.osmnotes.OsmNoteQuestType;
 import de.westnordost.streetcomplete.quests.baby_changing_table.AddBabyChangingTable;
-import de.westnordost.streetcomplete.quests.bike_parking_capacity.AddBikeParkingCapacity;
+import de.westnordost. streetcomplete.quests.bike_parking_capacity.AddBikeParkingCapacity;


nbolten · 2018-02-05T01:30:52Z

app/src/main/java/de/westnordost/streetcomplete/quests/QuestModule.java

-				new AddTactilePavingBusStop(o)
+				new AddBin(o)
 		};
+				//new AddPassengerInformationDisplay(o),


Remove comments and/or integrate above.

nbolten · 2018-02-05T01:48:10Z

app/src/main/java/de/westnordost/streetcomplete/quests/RangeQuestAnswerFragment.java

@@ -0,0 +1,64 @@
+package de.westnordost.streetcomplete.quests;


Make sure to use only lit=yes/no for tags submitted to OSM (and probably just use a yes/no answer in the interface for now).

nbolten · 2018-02-05T01:52:57Z

app/src/main/java/de/westnordost/streetcomplete/quests/bus_stop_lit/AddBusStopLitForm.java

+    @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState)
+    {
+        View view = super.onCreateView(inflater, container, savedInstanceState);
+        setContentView(R.layout.sidewalk_lit);


TODO: check this layout and make sure we use yes/no rather than range.

nbolten · 2018-02-05T01:53:20Z

...c/main/java/de/westnordost/streetcomplete/quests/bus_stop_shelter/AddBusStopShelterForm.java

@@ -0,0 +1,27 @@
+/*


Delete this file!

nbolten · 2018-02-05T02:04:10Z

...rc/main/java/de/westnordost/streetcomplete/quests/crossing_markings/AddCrossingMarkings.java

@@ -0,0 +1,44 @@
+package de.westnordost.streetcomplete.quests.crossing_markings;


Please disable for now - we will want to add as ways, hopefully under a different schema.

nbolten · 2018-02-05T02:05:07Z

...tnordost/streetcomplete/quests/curb_ramps_tactile_pavings/CheckCurbRamps_TactilePavings.java

+
+	@Override protected String getTagFilters()
+	{
+		//return "nodes, ways with "(("footway"="crossing") "and" ("kerb"="lowered"))";


Remove comment

nbolten · 2018-02-05T02:06:36Z

...tnordost/streetcomplete/quests/curb_ramps_tactile_pavings/CheckCurbRamps_TactilePavings.java

+	{
+		//return "nodes, ways with "(("footway"="crossing") "and" ("kerb"="lowered"))";
+
+		return "nodes, ways with (" +


This should be nodes with (kerb=lowered and !tactile_paving), or similar

Not displaying for some reason. nodes with kerb=lowered and !tactile_paving might also work. Debug for alternative explanations as well - maybe not finding the icon, etc?

Also: just disable this quest for now so we can get a release out there.

Also use a good icon!

nbolten · 2018-02-05T02:10:18Z

...tnordost/streetcomplete/quests/curb_ramps_tactile_pavings/CheckCurbRamps_TactilePavings.java

+		String yesno = answer.getBoolean(YesNoQuestAnswerFragment.ANSWER) ? "yes" : "no";
+		changes.add("curb_ramps", yesno);
+	}
+


Does this have an image? Would be handy for users to know what counts as 'tactile paving'.

But this isn't necessary to change before release - only if it's super super easy and fast.

nbolten · 2018-02-05T02:21:11Z

app/src/main/java/de/westnordost/streetcomplete/quests/sidewalk_lit/SidewalkLit.java

+
+    @Override protected String getTagFilters()
+    {
+       //return "nodes with (public_transport=platform or (highway=bus_stop and public_transport!=stop_position)) and !bench";


Remove comment

nbolten · 2018-02-05T02:22:49Z

app/src/main/java/de/westnordost/streetcomplete/quests/sidewalk_lit/SidewalkLit.java

+       // return "nodes with way[foot=yes][!lit]";
+        //return "ways with [highway="footway"] or way[foot="yes"] and !lit]";
+
+        return "nodes, ways with (" +


ways with (highway=footway or foot=yes) and !lit

(or similar)

nbolten · 2018-02-05T02:54:58Z

app/src/main/java/de/westnordost/streetcomplete/quests/sidewalk_surface/AddSideWalkSurface.java

+
+public class AddSideWalkSurface extends SimpleOverpassQuestType
+{
+    // well, all roads have surfaces, what I mean is that not all ways with highway key are


Remove comment

nbolten · 2018-02-05T02:55:32Z

app/src/main/java/de/westnordost/streetcomplete/quests/sidewalk_surface/AddSideWalkSurface.java

+
+    @Override protected String getTagFilters()
+    {
+        return "nodes, ways with (" +


Something like ways with (highway=footway or foot=yes) and !surface seems better, to me.

nbolten · 2018-02-05T02:56:26Z

.../main/java/de/westnordost/streetcomplete/quests/sidewalk_surface/AddSideWalkSurfaceForm.java

+public class AddSideWalkSurfaceForm extends AbstractQuestFormAnswerFragment {
+    public static final String SURFACE = "surface";
+
+    private final AddSideWalkSurfaceForm.Surface[] SURFACES = new AddSideWalkSurfaceForm.Surface[] {


When testing, make sure that the answer options make sense for footways, and that the images aren't of things that are obviously streets.

nbolten · 2018-02-05T02:56:52Z

app/src/main/res/layout/answer_range.xml

@@ -0,0 +1,30 @@
+<?xml version="1.0" encoding="utf-8"?>


Make sure to remove references to this - we want to use lit=yes/no.

nbolten · 2018-02-05T02:57:35Z

app/src/main/res/layout/busstop_shelter.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>


This is titled busstop_shelter but has references to tactilePavingSidewalkImage. This doesn't seem right!

nbolten · 2018-02-05T02:57:59Z

app/src/main/res/layout/sidewalk_lit.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>


Same as above - id of tactilePavingSidewalkImage probably shouldn't be used for sidewalk_lit

nbolten · 2018-02-05T02:59:09Z

app/src/main/res/values/strings.xml

    <string name="autosync_off">"Off"</string>
    <string name="quest_streetSurface_title">"What surface does this piece of road have?"</string>
    <string name="quest_streetSurface_name_title">"What surface does the road \"%s\" have here?"</string>
+    <string name="quest_sideWalk_name_title">"What surface does the sidewalk \"%s\" have here?"</string>


This made sense for streets, which often use the name tag (e.g. NE 15th St), but sidewalks should almost never have a name tag. If the quest module only shows this when a name tag is present, this shouldn't hurt, though.

nbolten · 2018-02-05T02:59:35Z

app/src/main/res/values/strings.xml

-    <string name="quest_busStopLit_title">"Is this bus stop well lit?"</string>
+    <string name="quest_busStopLit_title">"Is there lighting at this Bus stop?"</string>
    <string name="quest_busStopBench_title">"Does this bus stop have a bench?"</string>
+    <string name="quest_SidewalkLit_title">"How many lights do you see from the place you’re standing?"</string>


Make sure to change this to a yes/no question (same as the street lit question, basically)

nbolten · 2018-02-05T03:00:21Z

app/src/main/res/values/strings.xml

    <string name="quest_passengerInformation_name_title">"Does the bus stop \"%s\" have an electronic information display?"</string>
-    <string name="quest_busStopLit_name_title">"Is the bus stop \"%s\" well lit?"</string>
+    <string name="quest_busStopLit_name_title">"Is there lighting at the \"%s\" Bus stop?"</string>
+    <string name="quest_busStopLit_question2">"Are there one or more street lamps within 10 feet of this Bus stop?"</string>


I would ask a vaguer question, because the tag itself is also vaguer: is this bus stop lit?

nbolten · 2018-02-05T03:01:14Z

app/src/main/res/values/strings.xml

    <string name="quest_address_house_name_label">House name:</string>
    <string name="quest_buildingLevels_roofLevelsLabel2">levels in the roof</string>
    <string name="quest_buildingLevels_levelsLabel2">regular levels (not counting the roof)</string>
+    <string name="quest_range1">0</string>


If the quest range question type is kept, these should be named more specifically. It's unlikely that most range questions will always fit into the categories of 0, 1-3, and 4-7, so I'd call it quest_range_lit_1 or something.

nbolten

Thanks for making the previously suggested changes! Just a couple more and we're ready for release.

More things to double check:

What are the changeset tags? We should have project=opensidewalks in the changeset tags (not to be confused with the tags set on the nodes and ways).

nbolten · 2018-02-19T22:01:49Z

app/src/main/java/de/westnordost/streetcomplete/quests/QuestModule.java

-				new AddPassengerInformationDisplay(o),
-				new AddTactilePavingBusStop(o)
+				new AddBusStopLit(o)
+				//new AddBin(o)


Re-enable please!

nbolten · 2018-02-19T22:04:35Z

app/src/main/java/de/westnordost/streetcomplete/quests/QuestModule.java

 import de.westnordost.streetcomplete.quests.bike_parking_cover.AddBikeParkingCover;
 import de.westnordost.streetcomplete.quests.building_levels.AddBuildingLevels;
 import de.westnordost.streetcomplete.quests.bus_stop_lit.AddBusStopLit;



Remove unused quests! e.g. baby_changing_table

nbolten · 2018-02-19T22:18:50Z

...tnordost/streetcomplete/quests/curb_ramps_tactile_pavings/CheckCurbRamps_TactilePavings.java

+	{
+		//return "nodes, ways with "(("footway"="crossing") "and" ("kerb"="lowered"))";
+
+		return "nodes, ways with (" +


Not displaying for some reason. nodes with kerb=lowered and !tactile_paving might also work. Debug for alternative explanations as well - maybe not finding the icon, etc?

Also: just disable this quest for now so we can get a release out there.

nbolten · 2018-02-19T22:19:07Z

...tnordost/streetcomplete/quests/curb_ramps_tactile_pavings/CheckCurbRamps_TactilePavings.java

+	{
+		//return "nodes, ways with "(("footway"="crossing") "and" ("kerb"="lowered"))";
+
+		return "nodes, ways with (" +


Also use a good icon!

nbolten · 2018-02-19T22:20:10Z

app/src/main/java/de/westnordost/streetcomplete/quests/sidewalk_lit/SidewalkLit.java

+    {
+       return "ways with (" +
+                "((highway=footway) and (footway=sidewalk)" +
+                " or way=foot" +


I think this should be foot=yes

nbolten · 2018-02-19T22:48:41Z

app/src/main/java/de/westnordost/streetcomplete/quests/sidewalk_surface/AddSideWalkSurface.java

+ * Created by Neelam Purswani on 12-01-2018.
+ */
+
+public class AddSideWalkSurface extends SimpleOverpassQuestType


Swap to 'AddFootwaySurface' and remove (footway=sidewalk) so that this is a general-purpose footway surface annotator.

Also, we should explore all of the surface options to make sure we're (1) not missing anything and (2) not using any road-specific tags: https://taginfo.openstreetmap.org/keys/surface#values

nbolten · 2018-02-19T22:57:25Z

app/src/main/res/values/strings.xml

    <string name="quest_busStopShelter_title">"Does this bus stop have a shelter?"</string>
    <string name="quest_bin_title">"Does this bus stop have a waste bin?"</string>
-    <string name="quest_busStopLit_title">"Is this bus stop well lit?"</string>
+    <string name="quest_busStopLit_title">"Is there lighting at this Bus stop?"</string>


Add 'at night' for both of these

bilsch · 2019-06-17T21:09:36Z

I'm curious what is the status of this project / pull request? Are there still plans to continue with a mobile app? Android only or are there iOS plans as well?

MVP Push

225895f

uwtcat assigned neelampurswani Feb 5, 2018

nbolten reviewed Feb 5, 2018

View reviewed changes

After review code changes

0d363ec

nbolten reviewed Feb 19, 2018

View reviewed changes

neelampurswani added 2 commits February 19, 2018 15:30

Changes after 2nd review

80a56cd

fixed a typo

90690a1

Migrate from mapzen to nextzen maps

05f305c

		@@ -1,5 +1,7 @@
		package de.westnordost.streetcomplete.data.osm;

		import android.util.Log;

		@@ -0,0 +1,64 @@
		package de.westnordost.streetcomplete.quests;

		@@ -0,0 +1,44 @@
		package de.westnordost.streetcomplete.quests.crossing_markings;

MVP Push #5

Are you sure you want to change the base?

MVP Push #5

Uh oh!

Conversation

uwtcat commented Feb 5, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nbolten Feb 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nbolten Feb 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nbolten Feb 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nbolten left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nbolten Feb 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nbolten Feb 5, 2018 •

edited

Loading

nbolten Feb 19, 2018 •

edited

Loading

nbolten Feb 5, 2018 •

edited

Loading

nbolten Feb 19, 2018 •

edited

Loading