Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change permission to see reference projector #1015

Merged
merged 9 commits into from
Sep 23, 2024
Merged

Change permission to see reference projector #1015

merged 9 commits into from
Sep 23, 2024

Conversation

ostcar
Copy link
Member

@ostcar ostcar commented Sep 10, 2024

No description provided.

@ostcar ostcar added the feature label Sep 10, 2024
@ostcar ostcar added this to the 4.2 milestone Sep 10, 2024
@ostcar ostcar linked an issue Sep 10, 2024 that may be closed by this pull request
Projector: Permission change #1011
Closed
@bastianjoel bastianjoel assigned ostcar and unassigned bastianjoel and rrenkert Sep 11, 2024
@bastianjoel
Copy link
Member

Projections also need to be allowed.

@bastianjoel
Copy link
Member

meeting_mediafiles.go also needs to be adjusted.

Rest seems to work fine.

@ostcar
Copy link
Member Author

ostcar commented Sep 19, 2024

@bastianjoel @rrenkert can I merge this?

@ostcar ostcar assigned bastianjoel and rrenkert and unassigned ostcar Sep 19, 2024
bastianjoel
bastianjoel requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, mediafile projections will not work with this. meeting_mediafiles.go still just checks for ProjectorCanSee but now also needs to implement the autopilot check.

@bastianjoel bastianjoel assigned ostcar and unassigned rrenkert and bastianjoel Sep 20, 2024
@ostcar
Copy link
Member Author

ostcar commented Sep 21, 2024

No, mediafile projections will not work with this. meeting_mediafiles.go still just checks for ProjectorCanSee but now also needs to implement the autopilot check.

How should this be changed? Maybe:

The user can see a projection linked in `meeting_mediafile/projection_ids`.

As a reminder, a user can see a projection, if he has projector.can_manage or can see the projector linked in projection/current_projector_id.

@ostcar
Copy link
Member Author

ostcar commented Sep 21, 2024

@bastianjoel I changed it. Can you take another look?

bastianjoel
bastianjoel approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works :)

You can merge now.

@ostcar ostcar merged commit 0d89bba into OpenSlides:main Sep 23, 2024
3 checks passed
@ostcar ostcar deleted the restrictor_projector_autoupdate branch September 23, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianjoel bastianjoel bastianjoel approved these changes

@rrenkert rrenkert Awaiting requested review from rrenkert

Assignees

@ostcar ostcar

@bastianjoel bastianjoel

Labels
feature
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Projector: Permission change
4 participants
@ostcar @bastianjoel @rrenkert @peb-adr