Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add saml_id to search_users presenter #1807

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Add saml_id to search_users presenter #1807

merged 3 commits into from
Jul 12, 2023

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Jul 10, 2023

No description provided.

@reiterl reiterl added the enhancement General enhancement which is neither bug nor feature label Jul 10, 2023
@reiterl reiterl added this to the 4.1 milestone Jul 10, 2023
@reiterl reiterl requested a review from r-peschke July 10, 2023 10:17
@reiterl reiterl self-assigned this Jul 10, 2023
@reiterl reiterl linked an issue Jul 10, 2023 that may be closed by this pull request
presenter search_user should be extended by field saml_id #1788
Closed
r-peschke
r-peschke approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@r-peschke r-peschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing: Add the saml_id to the comment of the presenter class. Then you can merge without reviewing again:-)

@reiterl reiterl merged commit 50c96a3 into OpenSlides:main Jul 12, 2023
4 checks passed
@reiterl reiterl deleted the search-users-saml-id branch July 12, 2023 09:10
peb-adr added a commit that referenced this pull request Jul 17, 2023
@peb-adr
Merge main into stable/4.0.x. Update 20230717
4aacc34 
* commit '4375233e5e9b1f057b23a73432d0d90b0cfde6f1':
  Add context_id to search_for_id_by_external_id (#1806)
  Add saml_id to search_users presenter (#1807)
  Add `external_id` to `meeting.clone` (#1810)
  Fix user deletion with archived meetings (#1793)
  Fix weight assignment in agenda_item.create (#1799)
  Change permission of point of order cateory actions (#1805)
  Add point of order category model and actions, update speaker.create and meeting.update (#1785)
  Fix `meeting.clone` error (#1773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-peschke r-peschke r-peschke approved these changes

@jsangmeister jsangmeister jsangmeister approved these changes

Assignees

@reiterl reiterl

Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

presenter search_user should be extended by field saml_id
3 participants
@reiterl @r-peschke @jsangmeister