Raise proper error for meeting_id === null in mediafile.update
#2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjanott
approved these changes
Sep 17, 2024
| if "meeting_id" not in instance_fields: | ||
| if ( | ||
| "meeting_id" not in instance_fields | ||
| or instance["meeting_id"] is not None |
There was a problem hiding this comment.
This is not necessary due to the change in user.updates schema checks.
luisa-beerboom
deleted the
c-4135-ensure-proper-error-message-for-meeting-id-null-in-mediafile-update
branch
openslides-automation bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Raise proper error for in mediafile.update * Fix style * Remove unnecessary line
peb-adr
pushed a commit
that referenced
this pull request
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OpenSlides/openslides-client#4135
@Elblinator I leave merging to you, because I don't know, if you're going to want to put a staging label on this or not. IMO it's unnecessary, since changing the client will already fix the bug for the user. This is only a security feature.