Allow to edit own delegation via user.update_self #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjanott
approved these changes
Sep 25, 2024
| @@ -14,5 +16,9 @@ Updates the request user. Removes starting and trailing spaces from `username`. | |||
|
|
|||
| The given `gender` must be present in `organization/genders`. | |||
|
|
|||
| `meeting_id` is only for editing meeting-internal data, and the value will be thrown away afterwards. | |||
There was a problem hiding this comment.
How about:
meeting_id is only used for processing meeting-internal data and will be omitted otherwise.
There was a problem hiding this comment.
The purpose of my description was to point out that meeting_id won't be written into the data anywhere and is just additional information given to aid action-internal calculations.
Your proposition doesn't do that, so I won't change it-
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2503