read/write commands in backend #2652
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…582_read_write_commands_in_backend
- commented out defunct translate.py code (will need to be rewritten later) - removed custom di from main.py (comments still need to be disabled) - added with_database_context function back in (should work, didn't check though) - added RequestEvents back in as simple dataclasses - Fixed the base test classes (though BaseSystemTestCase may possibly need an replacement for the ShutdownService code (idk what that did tbh, so a comment was left) - Removed ConnectionHandler injection from test_save_saml_account (it was used in the change_nothing test to see whether an attempt to write data was actually made, idk if it's still necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read/write commands should be directed to an sql-part in the backend, that executes the commands with a direct connection to the database, using tables and not the collections with models-table only.
The reader part (openslides_backend/database/sql_read_database_backend_service.py) is connected and used, but still with collection/models-table. A template for the writer part could be found in openslides-datastore-service/datastore/writer/postgresql_backend/sql_database_backend_service.py, but has to be called analogue to the reader.