Fix numeric sorting (#2823)

OpenSlides · Sep 26, 2023 · 3800bde · 3800bde
1 parent e237b39
commit 3800bde
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/...components/motions/modules/motion-slide/components/motion-slide/motion-slide.component.ts b/...components/motions/modules/motion-slide/components/motion-slide/motion-slide.component.ts
@@ -211,7 +211,7 @@ export class MotionSlideComponent
 
         const paragraphNumbers = Object.keys(amendment.amendment_paragraphs)
             .map(x => +x)
-            .sort();
+            .sort((a, b) => a - b);
 
         return paragraphNumbers
             .map(paraNo => {
@@ -401,7 +401,7 @@ export class MotionSlideComponent
 
         const paragraphNumbers = Object.keys(motion.amendment_paragraphs)
             .map(x => +x)
-            .sort();
+            .sort((a, b) => a - b);
         const amendmentParagraphs: DiffLinesInParagraph[] = paragraphNumbers
             .map(paraNo =>
                 this.diff.getAmendmentParagraphsLines(

diff --git a/...ui/modules/sorting/modules/sorting-list/components/sorting-list/sorting-list.component.ts b/...ui/modules/sorting/modules/sorting-list/components/sorting-list/sorting-list.component.ts
@@ -237,7 +237,7 @@ export class SortingListComponent<T extends Selectable = Selectable> implements
             const newMultiSelectedIndex = multiSelectedIndex
                 .map(index => this.currentItems.findIndex(item => item.id === this.sortedItems[index].id))
                 .filter(index => index !== -1)
-                .sort();
+                .sort((a, b) => a - b);
             let newCurrentIndex = Math.min(event.currentIndex, this.currentItems.length - 1);
             if (newPreviousIndex === -1) {
                 newPreviousIndex = newMultiSelectedIndex.length ? newMultiSelectedIndex[0] : undefined;

diff --git a/client/src/app/ui/modules/sorting/modules/sorting-tree/services/tree.service.ts b/client/src/app/ui/modules/sorting/modules/sorting-tree/services/tree.service.ts
@@ -304,7 +304,7 @@ export class TreeService {
         if (!deleteIds.length) {
             return tree;
         }
-        deleteIds = deleteIds.sort();
+        deleteIds = deleteIds.sort((a, b) => a - b);
         tree = tree.sort((a, b) =>
             a.position != null && b.position != null ? a.position - b.position : b != null ? -1 : 0
         );