Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted agenda items are still displayed in list when navigation back #2497

Closed
bastianjoel opened this issue Jul 5, 2023 · 4 comments · Fixed by #2563 or #2718
Closed

Deleted agenda items are still displayed in list when navigation back #2497

bastianjoel opened this issue Jul 5, 2023 · 4 comments · Fixed by #2563 or #2718
Assignees
Labels
Milestone

Comments

@bastianjoel
Copy link
Member

  1. Create two topic items
  2. Delete one of the created items
  3. Open the other topic item
  4. Navigate back

The deleted topic item is in the topic list again. When reloading the page the deleted entry disappears.

@bastianjoel bastianjoel added the bug label Jul 5, 2023
@bastianjoel bastianjoel added this to the 4.1 milestone Jul 5, 2023
@luisa-beerboom luisa-beerboom self-assigned this Jul 26, 2023
@luisa-beerboom
Copy link
Member

In my pull request (#2563) I wrote this:

The problem is the following:

  1. Open agenda item list => agenda_list subscription is open
  2. Delete one item => The autoupdate sends a single-field update with the new value for the meetings agenda_item_ids, which will cause the client to consider these fields to be deleted, but NOT the autoupdate shared worker, which will continue to store them
  3. Go to the topic detail view
  4. Go back from the topic detail view => In the short moment where the parameters change, the detailview doesn't have an id and therefore subscribes to the agenda_list_minimal (as it now believes itself to be the new topic form, which needs the agenda list information) The shared worker will send the already stored data (see point two: it includes the deleted models) as the initial data for the subscription which will then be used by the client completely unfiltered
  5. See that the deleted models seem to have returned

Honestly we should do something about this quirk of our autoupdate handling system, but I didn't really have any idea what exactly can be done so I "fixed" it this way for now

We may need a follow up issue

@bastianjoel what is your opinion on this

@bastianjoel
Copy link
Member Author

I would consider #2563 a hotfix and therefore reopen this issue.

I think the best way to fix this is by removing deleted elements from the autoupdate cache.

@bastianjoel bastianjoel reopened this Aug 7, 2023
@Elblinator
Copy link
Member

It is still possible for the removed agenda items to be displayed in the agenda.

  1. add an election to the agenda, then remove it and then add it again
  2. you immediately go to motions and via multi-select add a motion to agenda
  3. the election you removed and added is displayed twice in the agenda list and if you saw the agenda-list with too many items then the items will also be displayed in the agenda itself

@bastianjoel
Copy link
Member Author

My approach solving this within the shared worker does not work as expected. We need to solve this somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants