Cleanup worker cache on delete #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisa-beerboom
approved these changes
Aug 29, 2023
|
If you delete a topic in topic detail, then the topic still only disappears with a reload or when you go into the detail view of this deleted topic again. But that is a different bug, created at a different place |
Elblinator
requested review from
Elblinator
and removed request for
emanuelschuetze
Elblinator
approved these changes
Aug 30, 2023
|
the additional problem is now in #2731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2497
The worker will now be notified if the client deletes models from the modelstore and will delete them within its internal state too.
Note that in order to test properly this the shared worker needs to be enabled.
This PR could have some side effects especially if there are misconfigured entries in
relations.tsor other bugs that result in models being accidentally deleted.