Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client relation handling doesn't do back-relations anymore #2789

Closed
luisa-beerboom opened this issue Sep 12, 2023 · 2 comments · Fixed by #3573
Closed

Client relation handling doesn't do back-relations anymore #2789

luisa-beerboom opened this issue Sep 12, 2023 · 2 comments · Fixed by #3573
Assignees
Labels
Milestone

Comments

@luisa-beerboom
Copy link
Member

It used to be that if one followed a relation field in a subscription, the contra-relation would automatically be filled for the other viewModel as well.

I.e. if one subscribed to a meeting and followed the motion_ids, the ViewMeeting would have a field motions with all of the corresponding ViewMotions and the corresponding ViewMotions would all have a field meeting that was filled with the ViewMeeting in question.

It seems like that has somehow stopped happening.
There have recently been multiple bugs that were caused because a subscription followed a field, but the counter-relation wasn't named anywhere in the fieldset, causing the connection to either not be built, or only be built one-way (I'm not quite sure which).
An example of this would be #2710 which could not be fixed without adding the back-relation for the meeting-users user_id field into the fieldset of the follow.

@luisa-beerboom luisa-beerboom added bug high needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time labels Sep 12, 2023
@luisa-beerboom luisa-beerboom added this to the 4.1 milestone Sep 12, 2023
@bastianjoel
Copy link
Member

I was not able to find anything that looks like doing something like that. I mainly looked for this in the datastore related services and model request handling.

@bastianjoel
Copy link
Member

bastianjoel commented Apr 17, 2024

There is actually an issue very specific to meeting users where this does not work.
Retrieving the meeting user for a given meeting is implemented in the repo very specifically. For that reason I think this is not problem in general.

@bastianjoel bastianjoel removed the needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants