Improve meeting user relation handling #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianjoel
added
clean up
enhancement
|
It might be that this comes with performance penalties in some scenarios. We should do some testing before merging this. |
luisa-beerboom
approved these changes
Apr 17, 2024
|
I tested this now a bit and could only observe a minor performance impact. |
|
I have a better Idea to make this more performant. Please do not merge yet. |
luisa-beerboom
approved these changes
Apr 23, 2024
Elblinator
approved these changes
Apr 30, 2024
peb-adr
pushed a commit
to peb-adr/openslides-client
that referenced
this pull request
Apr 30, 2024
peb-adr
pushed a commit
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2789
Also cleans up all places were
meeting_user_idswere subscribed.