-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement backend topic import #2244
Implement backend topic import #2244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In full screen the columns "title", "text", and "comment" should use kind of dynamic width.
- After performing an initial import a dialog "Stopped waiting for process(es)" comes up. Refreshing the list view shows all imported items.
- After perfoming an import the user can select a new file to import, but no new preview is shown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In full screen the columns "title", "text", and "comment" should use kind of dynamic width.
- After performing an initial import a dialog "Stopped waiting for process(es)" comes up. Refreshing the list view shows all imported items.
- After perfoming an import the user can select a new file to import, but no new preview is shown.
I only fixed the first one, as I can't replicate the others. Are you sure that your instance is working correctly @rrenkert ? |
Looks good so far. Some minor things:
Total topics: 19 better would be Total topics: 19
I can still replicate the one with the second file upload:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see my last comment.
Fixed some stuff, if the second file upload thing still happens, please give a better description |
Additional info for the second file upload: Happens in Chromium based browsers. Another point: When selecting a file for upload a scrollbar appears in the upper card. |
<div> | ||
<div style="margin-bottom: 5px"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure but afaik our linter should complain about inline style definitions. Use a class instead if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected now.
a0a7b28
into
OpenSlides:feature/remove-template-fields
Apart from the normal feature branches, this very specifically needs OpenSlides/openslides-backend#1697 in order to work properly.