Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement backend topic import #2244

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Apr 26, 2023

Apart from the normal feature branches, this very specifically needs OpenSlides/openslides-backend#1697 in order to work properly.

@luisa-beerboom luisa-beerboom added this to the 4.1 milestone Apr 26, 2023
@luisa-beerboom luisa-beerboom self-assigned this Apr 26, 2023
@luisa-beerboom luisa-beerboom marked this pull request as ready for review May 5, 2023 10:40
Copy link
Member

@rrenkert rrenkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In the fullscreen preview dialog the row content does not fit the table header:
    Tagesordnung - OpenSlides - rtf staging openslides com

  • Closing this dialog clears the embedded table.

  • The preview should disappear after successful import (offer a navigation to the agenda?)

@rrenkert rrenkert assigned luisa-beerboom and unassigned rrenkert May 15, 2023
@bastianjoel bastianjoel removed their assignment May 16, 2023
Copy link
Member

@rrenkert rrenkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In full screen the columns "title", "text", and "comment" should use kind of dynamic width.
  • After performing an initial import a dialog "Stopped waiting for process(es)" comes up. Refreshing the list view shows all imported items.
  • After perfoming an import the user can select a new file to import, but no new preview is shown.

Copy link
Member

@rrenkert rrenkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In full screen the columns "title", "text", and "comment" should use kind of dynamic width.
  • After performing an initial import a dialog "Stopped waiting for process(es)" comes up. Refreshing the list view shows all imported items.
  • After perfoming an import the user can select a new file to import, but no new preview is shown.

@luisa-beerboom
Copy link
Member Author

  • In full screen the columns "title", "text", and "comment" should use kind of dynamic width.

    • After performing an initial import a dialog "Stopped waiting for process(es)" comes up. Refreshing the list view shows all imported items.

    • After perfoming an import the user can select a new file to import, but no new preview is shown.

I only fixed the first one, as I can't replicate the others. Are you sure that your instance is working correctly @rrenkert ?

@rrenkert
Copy link
Member

rrenkert commented Jun 15, 2023

Looks good so far.

Some minor things:

  • Importing duplicated topics shows a misleading tooltip "Duplizieren" for the warning icon.
  • After a successful import the summary shows

Total topics: 19
Topics with warnings (will be skipped): 19

better would be

Total topics: 19
Topics skipped: 17
Topics created: 2

I only fixed the first one, as I can't replicate the others. Are you sure that your instance is working correctly @rrenkert ?

I can still replicate the one with the second file upload:

  • select a file and perform the import.
  • select the same file again -> nothing happens.

Copy link
Member

@rrenkert rrenkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my last comment.

@luisa-beerboom
Copy link
Member Author

Fixed some stuff, if the second file upload thing still happens, please give a better description

@rrenkert
Copy link
Member

Additional info for the second file upload: Happens in Chromium based browsers.

Another point: When selecting a file for upload a scrollbar appears in the upper card.

<div>
<div style="margin-bottom: 5px">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure but afaik our linter should complain about inline style definitions. Use a class instead if possible.

Copy link
Member

@rrenkert rrenkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected now.

@bastianjoel bastianjoel removed their assignment Aug 11, 2023
@rrenkert rrenkert removed their assignment Aug 11, 2023
@luisa-beerboom luisa-beerboom merged commit a0a7b28 into OpenSlides:feature/remove-template-fields Aug 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants