Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter buttons #2358

Conversation

luisa-beerboom
Copy link
Member

Closes #2357

Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After selecting filters the first click still doesn't deactivate the button.
It doesn't matter whether the x or anywhere else on the button is clicked.

@bastianjoel bastianjoel removed their assignment Jun 6, 2023
Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem right and I cannot replicate the issue on current main.

@luisa-beerboom
Copy link
Member Author

This does not seem right and I cannot replicate the issue on current main.

Have you tested it in firefox or chrome?

@Elblinator Elblinator removed their assignment Jun 14, 2023
@Elblinator Elblinator self-requested a review July 10, 2023 08:01
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X in participants is still not working immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't remove current filters via buttons in filter-bar sometimes
3 participants