Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search service dark mode #2437

Closed
wants to merge 3 commits into from
Closed

Fix search service dark mode #2437

wants to merge 3 commits into from

Conversation

bastianjoel
Copy link
Member

@bastianjoel bastianjoel commented Jun 20, 2023 •
edited
Loading

The background of list elements did not change in dark mode and were not readable.

@bastianjoel bastianjoel added this to the 4.1 milestone Jun 20, 2023
m-schieder
m-schieder approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@m-schieder m-schieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

luisa-beerboom
luisa-beerboom requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@luisa-beerboom luisa-beerboom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind on ngClass hacking can not possibly be better than just creating a new class in global-components-style.scss

luisa-beerboom
luisa-beerboom requested changes Jul 12, 2023
View reviewed changes
Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still prefer to have this in the global-components-style.scss, so that it is in the same place as other styles that change depending on light/dark mode and so that it may be easily re-used for lists that require similar styling

@bastianjoel
Copy link
Member Author

Change request will be implemented in #2616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisa-beerboom luisa-beerboom luisa-beerboom requested changes

@m-schieder m-schieder m-schieder approved these changes

Assignees

@bastianjoel bastianjoel

Labels
bug
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bastianjoel @m-schieder @luisa-beerboom