Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sort lists update only when relevant data is changed #2472

Merged

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Jun 28, 2023

Closes #2458

How it should work now upon update:

  1. If items were deleted they should be removed from the list, immediate sub-items should gain expansion and visibility level of the removed parent, all sub-items should be moved left
  2. If items are added they should be appended to the list
  3. Other changes like name-changes will not affect the list in any way. (i.e. the sort view will also not update names while opened)

Notes for testing: Please especially check if

  • Actual changes with the agenda item (for example change of topic title) still trigger an update
  • Other sort lists are negatively/positively affected (for example the motion call list), as this performs changes in the base class

@bastianjoel bastianjoel removed their assignment Jul 10, 2023
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open agenda sort view > Collapse all items > now trigger autoupdate in an other tab:

  • set done flag for agenda item => sort view expand!
  • add new topic item => sort view expand!
  • switch from public to internal => sort view expand!
  • add/edit some agend details (e.g. duration, comment) => sort view expand!

Similar problem in motion call list: collabse all motions > change metadata (e.g. state) in an other tab => call list view expand!

@luisa-beerboom luisa-beerboom force-pushed the 2458-keep-agenda-sort-collapsed branch from 57c5359 to 5b3a1b6 Compare July 14, 2023 15:09
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-review

@Elblinator Elblinator removed their assignment Jul 17, 2023
@emanuelschuetze emanuelschuetze merged commit f7cfd66 into OpenSlides:main Aug 15, 2023
3 checks passed
peb-adr added a commit to peb-adr/openslides-client that referenced this pull request Aug 22, 2023
* commit '3565b8492a7081287cfbdcfcab328dd5ea3de464': (87 commits)
  Ensure integer entries are displayed in backend-import preview list (OpenSlides#2672)
  Show general abstain button for Y/N elections (OpenSlides#2675)
  Fix projection dialog projection default editing (OpenSlides#2662)
  Fix poll title in autoupdate (OpenSlides#2665)
  Update eslint rules and cleanup (OpenSlides#2279)
  Updated translations (OpenSlides#2667)
  Adjust example file topic import (OpenSlides#2663)
  Fix qrcode generation without password (OpenSlides#2657)
  Fix user creation for new assignment_candidate (OpenSlides#2660)
  Revert and fix meeting list account detail (OpenSlides#2659)
  Fix meeting list after account detail request (OpenSlides#2652)
  Expand cross reference links in motions (OpenSlides#2649)
  Add referring motions to pdf export (OpenSlides#2647)
  Testing action service (OpenSlides#2645)
  Implement WiFi access data slide (OpenSlides#2444)
  Fix speaker creation with newly created user (OpenSlides#2617)
  Fix information in user delete dialog (OpenSlides#2640)
  Replace collection count system (OpenSlides#2634)
  Created CommaSeparatedListingComponent for enumerations in html template (OpenSlides#2603)
  Make sort lists update only when relevant data is changed (OpenSlides#2472)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Agenda sort collapse all/expand all
4 participants