Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save sort order only on change #2517

Merged
merged 10 commits into from
Aug 28, 2023
Merged

Save sort order only on change #2517

merged 10 commits into from
Aug 28, 2023

Conversation

luisa-beerboom
Copy link
Member

Closes #2166

@luisa-beerboom luisa-beerboom added the enhancement General enhancement which is neither bug nor feature label Jul 12, 2023
@luisa-beerboom luisa-beerboom added this to the 4.1 milestone Jul 12, 2023
Elblinator
Elblinator approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-review

emanuelschuetze
emanuelschuetze requested changes Aug 14, 2023
View reviewed changes
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow all admin changes if user is in motion list and on default sorting. That means: if admin change default sorting for all users (also for users with motion list in current window) the sorting changed without reload.

Elblinator
Elblinator approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-review

emanuelschuetze
emanuelschuetze requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admin changed default sorting -> for all users (also for users with custom sorting) the sorting changed to default.

@luisa-beerboom luisa-beerboom force-pushed the 2166-save-sort-order-only-on-change branch from 5825feb to 8098023 Compare August 16, 2023 09:41
emanuelschuetze
emanuelschuetze requested changes Aug 16, 2023
View reviewed changes
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem with same submitter/timestamp:
create some motions with same submitter/timestamp. sort by submitter or creation date. Now change default sort order in settings (as admin) -> motion order changed for user

@luisa-beerboom luisa-beerboom mentioned this pull request Aug 17, 2023
Open
@luisa-beerboom
Copy link
Member Author

@emanuelschuetze please test if this also fixes #2650
Given that the last commit should have introduced some stability, I believe it might actually fix it as well

Elblinator
Elblinator approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-review

@Elblinator Elblinator removed the request for review from bastianjoel August 18, 2023 06:23
@emanuelschuetze emanuelschuetze merged commit 85c1670 into OpenSlides:main Aug 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emanuelschuetze emanuelschuetze emanuelschuetze approved these changes

@bastianjoel bastianjoel bastianjoel approved these changes

@Elblinator Elblinator Elblinator approved these changes

Assignees

@emanuelschuetze emanuelschuetze

Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Save sort order only on change
4 participants
@luisa-beerboom @emanuelschuetze @bastianjoel @Elblinator