Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag_ids and agenda_type to agenda item duplication #2544

Merged

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Jul 21, 2023

Closes #2496

@luisa-beerboom luisa-beerboom added this to the 4.1 milestone Jul 21, 2023
@luisa-beerboom luisa-beerboom self-assigned this Jul 21, 2023
@jsangmeister
Copy link
Contributor

Well, we either restructure the client to use topic tags as well as agenda item tags or we change the backend to be able to set the agenda item tags directly, analogous to the other agenda item properties in https://github.com/OpenSlides/OpenSlides/wiki/topic.create#payload. Sooo the latter :D

The suggestion would then be to rename the tag_ids payload field to agenda_item_tag_ids and transfer these to the agenda item instead of the topic.

Furthermore, if the topic tags are not used at all, we could go ahead and remove them completely from the models.yml. I don't see any further ramifications in that if they are not used anywhere.

@luisa-beerboom
Copy link
Member Author

Well, we either restructure the client to use topic tags as well as agenda item tags or we change the backend to be able to set the agenda item tags directly, analogous to the other agenda item properties in https://github.com/OpenSlides/OpenSlides/wiki/topic.create#payload. Sooo the latter :D

The suggestion would then be to rename the tag_ids payload field to agenda_item_tag_ids and transfer these to the agenda item instead of the topic.

Furthermore, if the topic tags are not used at all, we could go ahead and remove them completely from the models.yml. I don't see any further ramifications in that if they are not used anywhere.

Sounds good to me

@jsangmeister
Copy link
Contributor

Opened OpenSlides/openslides-backend#1824 for this

@jsangmeister
Copy link
Contributor

OpenSlides/openslides-backend#1832 was merged and tag_ids were removed from topics alltogether, so this can be continued and the field removed in the client as well

@luisa-beerboom
Copy link
Member Author

For testing:
This PR might have consequences when creating an agenda item from assignments, motions and motion block, please check if these still work.

@luisa-beerboom luisa-beerboom marked this pull request as ready for review August 8, 2023 08:59
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The visibility is still not dublicated correctly.
If topic A is selected with multiselect, then the visibility is changed and then it is dublicated -> the original (and not current) visibility is dublicated.

If a tag is added to a motion the tag is not carried over to the agenda, the tags from a motion should be in the agenda as well

the states/phases from a motion/election are not carried to the agenda, which is at this time the correct behaviour because these descriptions are not tags in the tag system but descriptions of the state or phases. So at the current time that is a-okay!

@luisa-beerboom
Copy link
Member Author

If a tag is added to a motion the tag is not carried over to the agenda, the tags from a motion should be in the agenda as well

Talked to @MSoeb
This was not in OS3 therefore currently this is the correct behaviour and changes concerning this would be a new feature request.
Also it would honestly require quite a bit of planning and therefore it is not currently on the table

@Elblinator Elblinator changed the base branch from main to feature/remove-template-fields August 10, 2023 09:15
@Elblinator Elblinator changed the base branch from feature/remove-template-fields to main August 10, 2023 09:16
@Elblinator Elblinator self-requested a review August 10, 2023 09:16
@Elblinator Elblinator merged commit 74fd9bf into OpenSlides:main Aug 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix wrong and missing information of duplicated agenda items
4 participants