Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build in point of order restriction on closed #2553

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Build in point of order restriction on closed #2553

merged 2 commits into from
Jul 26, 2023

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Jul 24, 2023 •
edited
Loading

Closes #2550

Didn't test this because no backend yet, but it should work once the backend has been updated with the eventual backed PR for OpenSlides/openslides-backend#1826

TODO:
Change setting name in accordance with what was described in backend issue

@luisa-beerboom luisa-beerboom added feature waiting Waiting for some other PR/feature; more details in comments labels Jul 24, 2023
@luisa-beerboom luisa-beerboom added this to the 4.1 milestone Jul 24, 2023
@Elblinator Elblinator removed their assignment Jul 24, 2023
Elblinator
Elblinator approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-review

@luisa-beerboom luisa-beerboom requested review from Elblinator and removed request for MSoeb July 25, 2023 15:53
Elblinator
Elblinator previously requested changes Jul 26, 2023
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-review: fine

functionality: close LOS is doing nothing. no send request is sent and the LOS is not closed

@Elblinator Elblinator removed the waiting Waiting for some other PR/feature; more details in comments label Jul 26, 2023
@Elblinator Elblinator dismissed their stale review July 26, 2023 09:26

git problems, review not reliable

Elblinator
Elblinator approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-review and functionality

@Elblinator Elblinator merged commit 24e8988 into OpenSlides:main Jul 26, 2023
3 checks passed
peb-adr pushed a commit to peb-adr/openslides-client that referenced this pull request Jul 26, 2023
@luisa-beerboom @peb-adr
Build in point of order restriction on closed (OpenSlides#2553)
cbc991d 
* Build in point of order restriction on closed

* Change setting name
peb-adr added a commit that referenced this pull request Jul 27, 2023
@peb-adr @luisa-beerboom
Build in point of order restriction on closed (#2553) (#2559)
7e94534 
* Build in point of order restriction on closed (#2553)

* Build in point of order restriction on closed

* Change setting name

* Disable point of order button if point of order restriction is turned on

---------

Co-authored-by: luisa-beerboom <[email protected]>
Co-authored-by: Luisa <[email protected]>
@jsangmeister jsangmeister mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elblinator Elblinator Elblinator approved these changes

Assignees

@luisa-beerboom luisa-beerboom

Labels
feature
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Add setting to close LOS for point of orders
3 participants
@luisa-beerboom @Elblinator @MSoeb