Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement agenda pdf export dialog #2558

Conversation

luisa-beerboom
Copy link
Member

@luisa-beerboom luisa-beerboom commented Jul 25, 2023

unlink pr and Issue #2032

So far: Partially implemented a generic ExportDialogService (still has some bugs) and used it for Motions (didn't yet delete old MotionExportDialogComponent yet even though it should now be unused)

TODO:

  • Rebase to post-rtf main
  • Finish implementation of ExportDialog:
    • Not yet implemented in ExportDialog: If changeStateForFormat is set and the format is switched to one of the options, the state of the button should be set to the corresponding one
  • Fix bugs in ExportDialog:
    • A bug I found in the ExportDialog (there may be others)
      • change to XLSX
      • close dialogue
      • reopen dialogue
      • Pdf options row will not be completely disabled
  • Use ExportDialogService for agenda exports
  • Implement the functionality of the settings
  • The motion export dialog has since been extended with new fields, those should be added back in

@luisa-beerboom luisa-beerboom added this to the 4.1 milestone Jul 25, 2023
@luisa-beerboom luisa-beerboom self-assigned this Jul 25, 2023
@luisa-beerboom
Copy link
Member Author

I'm closing this since it's hopelessly out of date by now and will be further in conflict with the motion import PR (#3042), which is why it would probably be simpler to just start over

@luisa-beerboom luisa-beerboom deleted the 2032-agenda-pdf-export-dialog branch November 24, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant