2556 wrong dialog text #2572
Merged
2556 wrong dialog text #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisa-beerboom
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Code review -> approved
Did some testing as well:
The workflow detail delete is basically a double-dialog.
You open the first dialog, click on the delete-button, then a second dialog opens.
This is probably suboptimal from a design perspective, what do you think @MSoeb ?
Elblinator
changed the base branch from
main
to
feature/remove-template-fields
emanuelschuetze
changed the base branch from
feature/remove-template-fields
to
main
emanuelschuetze
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2556
additional change in the code for dialogs - these should not change any function or dialog text!!:
dialog text while