Created CommaSeparatedListingComponent for enumerations in html template #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianjoel
approved these changes
Aug 11, 2023
emanuelschuetze
requested changes
Aug 14, 2023
There was a problem hiding this comment.
Looks good. One remark in motion pdf where an additional ":" is used:
Motion PDF shows "Zeile 2: (Änderungsempfehlung"):
Motion detail shows "Zeile 2 (Änderungsempfehlung)":
Please remove the ":" in motion pdf - motion detail and pdf should contain the the same layout/string(s).
Elblinator
previously approved these changes
Aug 14, 2023
Elblinator
requested review from
Elblinator
and removed request for
Elblinator
bastianjoel
approved these changes
Aug 14, 2023
emanuelschuetze
approved these changes
Aug 15, 2023
|
@emanuelschuetze this was explicitely not wanted in #2399 (comment) since this way, if you have a lot of strings, they will all be put in one line without any line breaks. Depending on the available space, listing more than 4-5 items is then not possible without the line running out of bounds. What is the problem with |
peb-adr
added a commit
to peb-adr/openslides-client
that referenced
this pull request
Aug 22, 2023
* commit '3565b8492a7081287cfbdcfcab328dd5ea3de464': (87 commits) Ensure integer entries are displayed in backend-import preview list (OpenSlides#2672) Show general abstain button for Y/N elections (OpenSlides#2675) Fix projection dialog projection default editing (OpenSlides#2662) Fix poll title in autoupdate (OpenSlides#2665) Update eslint rules and cleanup (OpenSlides#2279) Updated translations (OpenSlides#2667) Adjust example file topic import (OpenSlides#2663) Fix qrcode generation without password (OpenSlides#2657) Fix user creation for new assignment_candidate (OpenSlides#2660) Revert and fix meeting list account detail (OpenSlides#2659) Fix meeting list after account detail request (OpenSlides#2652) Expand cross reference links in motions (OpenSlides#2649) Add referring motions to pdf export (OpenSlides#2647) Testing action service (OpenSlides#2645) Implement WiFi access data slide (OpenSlides#2444) Fix speaker creation with newly created user (OpenSlides#2617) Fix information in user delete dialog (OpenSlides#2640) Replace collection count system (OpenSlides#2634) Created CommaSeparatedListingComponent for enumerations in html template (OpenSlides#2603) Make sort lists update only when relevant data is changed (OpenSlides#2472) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2500