Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove paginator from history page #2882

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Remove paginator from history page #2882

merged 3 commits into from
Oct 24, 2023

Conversation

reiterl
Copy link
Member

@reiterl reiterl commented Oct 12, 2023

Closes #2875

@reiterl reiterl added the enhancement General enhancement which is neither bug nor feature label Oct 12, 2023
@reiterl reiterl added this to the 4.2 milestone Oct 12, 2023
@bastianjoel bastianjoel removed their assignment Oct 12, 2023
Elblinator
Elblinator approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function

bastianjoel
bastianjoel requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MatPaginatorModule should also be remove from history.module.ts

@bastianjoel bastianjoel assigned reiterl and unassigned Elblinator Oct 20, 2023
@reiterl
Copy link
Member Author

reiterl commented Oct 23, 2023

Ah, okay. I have removed the pagenator from the history module. Missed that.

@reiterl reiterl assigned bastianjoel and unassigned reiterl Oct 23, 2023
@bastianjoel bastianjoel merged commit 1f6e035 into OpenSlides:main Oct 24, 2023
3 checks passed
@reiterl reiterl deleted the rm-history-paginator branch October 24, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianjoel bastianjoel bastianjoel approved these changes

@Elblinator Elblinator Elblinator approved these changes

Assignees

@bastianjoel bastianjoel

Labels
enhancement General enhancement which is neither bug nor feature
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Change chronik pages
3 participants
@reiterl @bastianjoel @Elblinator