Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meeting history using wrong user repo #2889

Merged
merged 5 commits into from
Oct 23, 2023
Merged

Fix meeting history using wrong user repo #2889

merged 5 commits into from
Oct 23, 2023

Conversation

bastianjoel
Copy link
Member

resolves #2885

@bastianjoel bastianjoel added this to the 4.2 milestone Oct 12, 2023
@bastianjoel bastianjoel modified the milestones: 4.2, 4.1 Oct 12, 2023
luisa-beerboom
luisa-beerboom reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually work if you select something?

emanuelschuetze
emanuelschuetze previously requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work for me. All accounts from other meetings are still listed in history select input - if you open account list before.

luisa-beerboom
luisa-beerboom approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small optional remark

.../src/app/site/pages/meetings/pages/history/components/history-list/history-list.component.ts Outdated Show resolved Hide resolved
@luisa-beerboom luisa-beerboom removed their assignment Oct 13, 2023
Elblinator
Elblinator approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@Elblinator Elblinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function

@Elblinator Elblinator enabled auto-merge (squash) October 23, 2023 06:55
@Elblinator Elblinator merged commit c1889b9 into OpenSlides:main Oct 23, 2023
2 checks passed
@bastianjoel bastianjoel deleted the 2885-fix-history-user-repo branch October 23, 2023 07:34
m-schieder added a commit that referenced this pull request Nov 1, 2023
@m-schieder
Merge main into stable/4.0.x. Update 20231101
f1bcdbd 
* commit 'de1c41c440e2769f30db848afed513db289c3dba':
  Add missing field to history subscription (#2915)
  Update projection-edit-dialog to fix bugs (#2891)
  Fix meeting history using wrong user repo (#2889)
  Fix conflicting amendment projection (#2887)
  Add perm check to remove from motion block (#2883)
  Change shown sequential number and add a space (#2881)
  Update global search to show marks bolder (#2879)
  Prevent add ballot if deleted users (#2873)
  Fix autoupdate request flooding after logout (#2907)
  Bump tinymce from 5.10.7 to 5.10.8 in /client (#2920)
  Add tests for the color service (#2928)
  Bump @babel/traverse from 7.21.3 to 7.23.2 in /client (#2910)
  Update angular (#2810)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elblinator Elblinator Elblinator approved these changes

@luisa-beerboom luisa-beerboom luisa-beerboom approved these changes

@emanuelschuetze emanuelschuetze Awaiting requested review from emanuelschuetze

Assignees

@Elblinator Elblinator

Labels
bug
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

All organization users displayed in participant history select
4 participants
@bastianjoel @emanuelschuetze @Elblinator @luisa-beerboom