Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tinymce with tiptap #2890

Merged
merged 106 commits into from
Jul 15, 2024
Merged

Conversation

bastianjoel
Copy link
Member

@bastianjoel bastianjoel commented Oct 13, 2023

resolves #1046
resolves #3311

TODO:

  • Change marked text color
  • Images
  • Text color within marks gets discarded when parsing from html
  • TinyMCE output compatibility
    • Marked text (TinyMCE: surround with span, style attribute with background-color)
      • Keep the background color
  • iFrame / Replace topic editor
  • Mso List start number
  • Table styling inside editor display borders
  • Menu layout should be in one line

@bastianjoel bastianjoel self-assigned this Oct 13, 2023
@bastianjoel bastianjoel changed the title Replace tinymce with prosemirror Replace tinymce with something else Oct 13, 2023
@Elblinator
Copy link
Member

If bullet points are copied with office 365, then the bullet point is a special symbol but not recognised as a bullet point

Here a screenshot:
009
The upper point is an actual bullet point
The lower point is the "bullet point" which was copied

@MSoeb
Copy link

MSoeb commented Oct 27, 2023

Info: Editor should have a the possibility to edit the text via source code. Just like the TinyMCE one.

@bastianjoel
Copy link
Member Author

bastianjoel commented Oct 27, 2023

I added the functionality but we might need to discuss the use cases for it as Prosemirror/Tiptap do not work with HTML internally and therefore only support tags and attributes that were specified beforehand.
We need to test this but I assume that this might lead to unexpected behavior for some users. Restricting that feature for motions might also give us some benefits for the diff algorithm as it might makes editor output more predictable.

@bastianjoel bastianjoel requested a review from MSoeb July 10, 2024 11:47
@bastianjoel bastianjoel assigned MSoeb and unassigned bastianjoel Jul 10, 2024
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When old content with images is opened and saved with the new editor, two problems occur.

  1. the image changed it's position.
  2. if the source code is also opened and closed with OK, the image is reduced in size.

Both cases must not occur as they change old content.

For Repro please contact me. Need to show it on a specific instance.

@bastianjoel bastianjoel assigned bastianjoel and unassigned MSoeb Jul 12, 2024
@bastianjoel bastianjoel requested a review from MSoeb July 15, 2024 09:35
@bastianjoel bastianjoel assigned MSoeb and unassigned bastianjoel Jul 15, 2024
@rrenkert rrenkert dismissed emanuelschuetze’s stale review July 15, 2024 13:28

The change request is done.

@rrenkert rrenkert merged commit 55dc8e0 into OpenSlides:main Jul 15, 2024
2 checks passed
@bastianjoel bastianjoel deleted the 1046-replace-tinymce branch July 15, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix projector-detail > edit/add messages Replace the tinymce editor with another one
6 participants