Add tests to openslides-status service #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianjoel
reviewed
Nov 2, 2023
Comment on lines
30
to
31
| service.reset(); | ||
| expect(actualValue).toBe(true); |
There was a problem hiding this comment.
This seems odd. If you don't want to change that you might instead want to test the Promise returned by the service.
There was a problem hiding this comment.
I removed the reset method.
The reset method is lava code.
|
The reset method is not used, so I cut it and updated the tests. |
bastianjoel
approved these changes
Nov 7, 2023
m-schieder
added a commit
that referenced
this pull request
Nov 9, 2023
* commit '2904fb2ac5d9b8a39fff48e8ea04353077e0a3dc': (26 commits) Make user option title load - alternative (#2995) Fix safari chyron font (#2990) Move motion block recommendation text after icon (#2979) Global search style clean-up (#2977) Add tests to openslides-status service (#2960) Correcting translations (#2980) Fix line numbers at change context remainder (#2970) (#2978) Update los contribution count (#2968) Mediafile support recursive folder download (#2866) Add validators to email and default_vote_weight in some dialog (#2911) Fix a problem in the poll service (#2963) Fix version history-link (#2967) Add missing sorting for filter properies in filter list (#2953) Update way to check for agenda-item-list (#2965) Use gramatically correct email snackbar messages (#2954) Update agenda projection (#2964) Change duration of request of speakers to hours:mins (#2948) Update sort and filter at meeting switch (#2947) Fix missing star icon in motion-block (#2952) Bump crypto-js from 4.1.1 to 4.2.0 in /client (#2950) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure, that the reset method is correct. It doesn't change the isStable to false.