Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update material radio-buttons #3001

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Update material radio-buttons #3001

merged 3 commits into from
Nov 23, 2023

Conversation

Elblinator
Copy link
Member

part of #2934

changes:

  • Labels are smaller and further away from the radio button
  • The touch target is now much larger and more accessible
  • Radio button labels are no longer width: 100%. This helps prevent users from accidentally selecting a radio when clicking on whitespace that appears inert on the page.

@Elblinator Elblinator marked this pull request as ready for review November 10, 2023 13:35
@bastianjoel bastianjoel mentioned this pull request Nov 10, 2023
Closed
22 tasks
@Elblinator Elblinator removed the request for review from rrenkert November 13, 2023 07:22
@bastianjoel bastianjoel removed their assignment Nov 17, 2023
bastianjoel
bastianjoel approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and appearance tested

@bastianjoel bastianjoel enabled auto-merge (squash) November 23, 2023 11:44
@bastianjoel bastianjoel merged commit f306d8c into OpenSlides:main Nov 23, 2023
2 checks passed
m-schieder added a commit that referenced this pull request Nov 23, 2023
@m-schieder
Merge main into stable/4.0.x. Update 20231123
22d1c77 
* commit '8b36d05f8bf4f192ab3be28f65c936d878a9b06f':
  Update nanocosmos url (#3041)
  Update material radio-buttons (#3001)
  Fix multiselect motion move in agenda (#3036)
  Fix projector header height (#3031)
  Remove alternating colour in global search (#3039)
  Cache search term from global search (#3032)
  Global search improvements (#3013)
  Fix vote weight 0 not displayed (#3034)
  Motion detail run change reco on motion id change (#3000)
  Update getTitle of speaker with deleted user (#2895)
  Fix topic poll create after meeting create (#3026)
  Add tests to connection-status service (#3003)
  Migrate mdc tooltips (#2999)
  Add tests to auth-token service (#3027)
  Add tests to fallback-routes service (#3022)
  Fix cr projection with start_line_number set (#3020)
  Fix amendment slide line numbering (#3018)
  Bump tinymce from 5.10.8 to 5.10.9 in /client (#3016)
@Elblinator Elblinator deleted the 2934-radio branch November 24, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianjoel bastianjoel bastianjoel approved these changes

@MSoeb MSoeb Awaiting requested review from MSoeb

Assignees

@MSoeb MSoeb

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Elblinator @bastianjoel @rrenkert @MSoeb