Update mdc form components #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
|
@Elblinator already tested most pages affected by the placeholder to label change. |
MSoeb
previously requested changes
Dec 1, 2023
There was a problem hiding this comment.
Found various issues:
- General: If the new boxes are empty, i.e. no text is visible in the box, then only half of the text at the top of the box is visible. This occurs globally for all boxes. It is clearly visible in the settings of a meeting.
Organization level:
- -- Committees > create new meeting form: Between 'Duplicate from' and ' language' box is no space. here should be more space between text.
- -- Design / edit: The box is to small. An unnecessary scrollbar appears.
Meeting:
- Motions > Motion detail view > poll creation > voting duration: Text is not aligned
- Elections > new ballot > Analog ballot: The space between the boxes is too small, if the boxes contains values.
- Elections > new ballot > voting duration: Text is not aligned
- Files > Upload: Add a new file. The UI of the Upload menu is too small to handle the new boxes. (This also appears on Orga level.
- Projector > Edit projector: Box right to the pixel size is not useable anymore.
- Projector > Edit projector: Projector defaults text is redundant. The description in the box can be deleted.
- History: If an option in the left and middle box is slected, the 'Refresh' information snaps to another line, because there is no more space between the middle and the right box.
- Chat > Chat creation form: If the name field is empty, you have entered something and deleted it again, a warning appears. If you now select a group in the middle box, the warning in the top box and the text in the middle box are very close to each other.
- Settings > MatSelect open arrows are too far at the edge
I think this was added there to separate the input from the group above. For that reason I would leave it there. |
m-schieder
added a commit
that referenced
this pull request
Jan 12, 2024
* commit '8163622a3c432ba9c23af075bdaf319bef342563': Fix NullInjectorErrors (#3135) Bump follow-redirects from 1.15.2 to 1.15.4 (#3130) Clean up several constructors (#3129) Stop motion list from showing forwarded motions (#3123) Fix preview on submitter edit (#3126) Fix motion block toolbar (#3122) Fix access group setting in mediafiles (#3120) Add CI to feature branches (#3108) Update mdc form components (#3002) Add tests to lifecycle service (#3075) Imports: Make sure file can be re-added after import fails with error (#3102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this seems to resolve #2925
part of #2934
CAUTION: This changes the appearance of all input fields heavily.