Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update material table #3694

Closed
wants to merge 4 commits into from
Closed

Conversation

Elblinator
Copy link
Member

@Elblinator Elblinator commented May 22, 2024

part of #2934

the following view pages were changed:

  • history
  • groups
  • category-detail
  • workflow-detail

@Elblinator Elblinator added this to the 4.2 milestone May 22, 2024
@Elblinator Elblinator self-assigned this May 22, 2024
@Elblinator Elblinator mentioned this pull request May 23, 2024
22 tasks
@Elblinator Elblinator marked this pull request as ready for review May 23, 2024 06:42
@Elblinator Elblinator assigned bastianjoel and MSoeb and unassigned Elblinator May 23, 2024
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are various minor, recurring problems and one major one.

Minor problems: Various titles that were previously slightly gray and not bold are now bold. This occurs with various content in the instance. A good example can be found in the chronicle.

Major problem: The width of the boxes has changed in the Autopilot. They are now narrower and the speaking times widget is wider.

Both should be fixed.

@Elblinator Elblinator assigned Elblinator and unassigned bastianjoel and MSoeb May 23, 2024
@Elblinator
Copy link
Member Author

The titles in e.g. motion-meta-data and the size of the boxes in the autopilot were not changed by this PR and this should therefore not be fixed here

The titles/appearances which should be slightly different are in the four named views (history, groups, category-detail, workflow-detail).
The difference in appearance is the new default, I strongly recommend not diverting from the new default

@Elblinator Elblinator requested a review from MSoeb May 24, 2024 06:47
@Elblinator Elblinator assigned bastianjoel and MSoeb and unassigned Elblinator May 24, 2024
@bastianjoel bastianjoel self-requested a review May 29, 2024 15:15
Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge into main.
This PR is included in #3706. I will take care of the future changes made here and add them there.

The changes made here can also be tested here.

@bastianjoel
Copy link
Member

closed in favor of #3706

@bastianjoel bastianjoel closed this Jun 5, 2024
@Elblinator Elblinator deleted the 2934-mdc-table branch August 2, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants