Fix amendment list performance #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastianjoel
added
enhancement
luisa-beerboom
approved these changes
Aug 5, 2024
MSoeb
reviewed
Aug 16, 2024
There was a problem hiding this comment.
I've spoken with @emanuelschuetze about it the current state. And we want to talk you you about it. We'Ve found some good and not so good points, which could be improved. Also we've spoken about a heavy test with lots of data (amendment to one motion) and how well you PR can handle it and where are the limits.
TLDR: Let's speak about it in the next weeks.
|
Is it possible that the response time for the amendment texts is the problem here then? |
rrenkert
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes amendment list performance by just calculating diffs of amendments in viewport.
resolves #3014