Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filters to poll single votes #3978

Merged
merged 31 commits into from
Aug 29, 2024

Conversation

bastianjoel
Copy link
Member

@bastianjoel bastianjoel commented Aug 5, 2024

resolves #3899

@bastianjoel bastianjoel self-assigned this Aug 5, 2024
@bastianjoel bastianjoel marked this pull request as draft August 7, 2024 07:00
@bastianjoel bastianjoel assigned Elblinator and unassigned bastianjoel Aug 7, 2024
@Elblinator Elblinator assigned bastianjoel and unassigned Elblinator Aug 13, 2024
@Elblinator
Copy link
Member

The filters have to be hidden in a non-nominal vote

The filters are currently displayed in ballots and topic polls as well but they are not working
They either have to work there as well or they have to hidden

please change my crude "cat.value" = "Y", "N", "A", to the actual words

@bastianjoel bastianjoel marked this pull request as ready for review August 14, 2024 12:01
@bastianjoel bastianjoel assigned reiterl and MSoeb and unassigned bastianjoel Aug 14, 2024
@Elblinator Elblinator assigned Elblinator and unassigned reiterl and MSoeb Aug 15, 2024
@Elblinator Elblinator removed their assignment Aug 16, 2024
@rrenkert rrenkert removed the request for review from reiterl August 19, 2024 14:26
@bastianjoel bastianjoel marked this pull request as ready for review August 28, 2024 09:37
@bastianjoel bastianjoel requested a review from MSoeb August 28, 2024 09:37
@bastianjoel bastianjoel assigned MSoeb and unassigned bastianjoel Aug 28, 2024
Copy link
Member

@emanuelschuetze emanuelschuetze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rename "Weighted votes" to "Valid votes"
  • Hide line "Ballot cast: ..." if vote weight is disabled / not used in poll.
  • Line "Weighted votes": add abstain to total, and add abstain value (without percent!)
  • Line "Ballot cast": add abstain value

@Elblinator Elblinator merged commit 5872c11 into OpenSlides:main Aug 29, 2024
2 checks passed
@bastianjoel bastianjoel deleted the 3899-poll-filter-bar-chart branch August 29, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poll detail view: new filters and bar chart
5 participants